Skip to content

epds-login: correct prompt login PAR guidance - #248

Open
Kzoeps wants to merge 1 commit into
mainfrom
docs/fix-prompt-par-guidance
Open

epds-login: correct prompt login PAR guidance#248
Kzoeps wants to merge 1 commit into
mainfrom
docs/fix-prompt-par-guidance

Conversation

@Kzoeps

@Kzoeps Kzoeps commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • document prompt=login as a PAR parameter for OAuth/OIDC semantics
  • retain the ePDS-specific authorization-URL mirror that bypasses cookie-session reuse
  • show hand-rolled clients setting the parameter in PAR

Summary by CodeRabbit

  • Documentation
    • Updated ePDS login guidance to require the prompt=login parameter in both the PAR request and authorization redirect URL.
    • Added a Flow 1 example and clarified the dual-location requirement in the pitfalls guidance.

@changeset-bot

changeset-bot Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 312906c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
epds-demo Ready Ready Preview Aug 19, 2026 3:53pm

Request Review

@railway-app

railway-app Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

🚅 Deployed to the ePDS-pr-248 environment in ePDS

Service Status Web Updated (UTC)
@certified-app/demo untrusted ✅ Success (View Logs) Web Aug 19, 2026 at 7:20 am
@certified-app/pds-core ✅ Success (View Logs) Web Aug 19, 2026 at 7:20 am
@certified-app/demo ✅ Success (View Logs) Web Aug 19, 2026 at 7:19 am
@certified-app/auth-service ✅ Success (View Logs) Web Aug 19, 2026 at 7:19 am

@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ee30941e-3cb0-4351-ba54-fc5fb545b723

📥 Commits

Reviewing files that changed from the base of the PR and between d91b905 and 59d8f37.

📒 Files selected for processing (1)
  • .agents/skills/epds-login/SKILL.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The ePDS login skill now requires prompt=login in both the PAR request and authorization redirect URL. It updates the Flow 1 example and related pitfall guidance.

Changes

ePDS login guidance

Layer / File(s) Summary
Document dual prompt=login placement
.agents/skills/epds-login/SKILL.md		 The Flow 1 example adds prompt=login to the PAR request and retains it in the authorization URL. The pitfalls table explains the effects of both parameters.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 59d8f

This is a localized documentation-only update with no production behavior changes; no actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: ashex

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: correcting ePDS guidance for the prompt=login parameter in PAR requests.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch docs/fix-prompt-par-guidance

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coveralls-official

coveralls-official Bot commented Aug 19, 2026 •
edited
Loading

Copy link
Copy Markdown

Coverage Report for CI Build 32272601204

Coverage remained the same at 60.234%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.

Coverage Stats

Coverage Status
Relevant Lines: 3202
Covered Lines: 1925
Line Coverage: 60.12%
Relevant Branches: 2006
Covered Branches: 1212
Branch Coverage: 60.42%
Branches in Coverage %: Yes
Coverage Strength: 9.65 hits per line
💛 - Coveralls

@Kzoeps
Kzoeps force-pushed the docs/fix-prompt-par-guidance branch from d91b905 to 59d8f37 Compare August 19, 2026 15:22
@Kzoeps
Kzoeps force-pushed the docs/fix-prompt-par-guidance branch from 59d8f37 to 312906c Compare August 19, 2026 15:52
@sonarqubecloud

sonarqubecloud Bot commented Aug 19, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Kzoeps
Kzoeps requested review from Ashex and kristoferlund August 20, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ashex Ashex Awaiting requested review from Ashex
@kristoferlund kristoferlund Awaiting requested review from kristoferlund

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Kzoeps